ARROW-12263: [Dev][Packaging] Move Crossbow to Archery #9913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
force-pushed
the
crossbow-to-archery
branch
from
393201d to
6fb6e03
Compare
Member
Author
|
@github-actions crossbow submit -g wheel |
kszucs
force-pushed
the
crossbow-to-archery
branch
from
0661c5c to
4937b82
Compare
Member
Author
|
@github-actions crossbow submit -g wheel |
kszucs
changed the title
Member
Author
|
Submitted nightly jobs manually: https://github.com/ursacomputing/crossbow/branches/all?query=build-187 |
kou
approved these changes
Apr 8, 2021
Member
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
I can't review all codes but it seems to be working fine.
Member
Author
|
I need to adjust the comment bot which I'm testing on my fork. |
kszucs
force-pushed
the
crossbow-to-archery
branch
from
8117519 to
2033b64
Compare
Member
Author
|
The comment bot works as expected kszucs#18 (comment) |
kou
reviewed
Apr 10, 2021
|
|
||
| # initialize the crossbow build's target repository | ||
| target = Target.from_repo(arrow, version=arrow_version, | ||
| remote=pull_request.base.repo.clone_url) |
Member
There was a problem hiding this comment.
It seems that pull_request.base always refers apache/arrow not ${USER}/arrow: #9977 (comment)
Should w use pull_request.head here?
Member
Author
There was a problem hiding this comment.
We should, sorry about that! The fix is at #9978
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main highlights: